This repository has been archived by the owner on Dec 11, 2018. It is now read-only.
Iván Pérez #31
Open
Iván Pérez #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 15, 2018 12:14
Tweet entity was updated to increase the size of the content from 140 to 2000 (it has to store long messages with URLs). It's not a good solution.
added 12 commits
April 15, 2018 22:32
…GET /tweet endpoint at initial commit.
There are more missing verifications and tests to do, but I wanted to include this at the pull-request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here comes my pull request.
I would like to do more improvements, there are some pieces of code that I don't like and the test could be improved and simplified (more "unit" oriented)... but I think it's enough for the test.